Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed german UI translations, added missing values, added config for AUT #193

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kaibrockelt
Copy link

Several fixes on the german language:
Missing strings added for german:

  • cartNoteLabel
  • identifiedUserMessage
  • requiredField

Configuration for AUSTRIA copied from german (AUT)

String replacements for delivery times adapted to the German language.

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Apr 24, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

Warnings
⚠️

package.json was changed, but not yarn.lock (vice-versa) [:bulb: are you sure this is right?]

⚠️

Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 8578, PR deletions = 6324

Generated by 🚫 dangerJS against 3f844cf

@kaibrockelt kaibrockelt requested a review from lucvysk April 24, 2023 10:11
@lucvysk
Copy link
Contributor

lucvysk commented Apr 24, 2023

@kaibrockelt Can you please run rpm run app to build the final files?

@lucvysk
Copy link
Contributor

lucvysk commented Apr 24, 2023

And please, update the changelog

kaibrockelt and others added 3 commits April 24, 2023 15:43
logging my changes
…into i18n-DE-AT

pulling changelog updates i did on github
@albertm805
Copy link
Contributor

@kaibrockelt Can you fix merge conflicts, fix the lint errors and also run yarn run app again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants